[dpdk-ci] [PATCH v4 7/7] tests: add checkpatch

Wei, FangfangX fangfangx.wei at intel.com
Wed Dec 7 06:48:55 CET 2016


Hi Thomas,
I try to use " send-patch-report.sh" with your suggestion, but after run it, nothing happened.
The command shows as below:

echo $report | tools/send-patch-report.sh -t "[PATCH, v3] net/i40evf: fix reporting of imissed packets" -f "tcrugnale at sandvine.com" -m "1481055381-14243-1-git-send-email-tcrugnale at sandvine.com" -p "dev.dpdk.org" -l "Intel Per-patch compilation check" -s "SUCCESS" -d "Compilation OK"

In case it was detected as a private patch, I also try to run it with my email address: -f "fangfangx.wei at intel.com", nothing happened, and I didn't receive this email either.

Is there still any error when I use the script? (BTW: This is the report about patch 17720)

Best Regards
Fangfang Wei

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] 
Sent: Tuesday, December 6, 2016 4:40 PM
To: Wei, FangfangX <fangfangx.wei at intel.com>
Cc: ci at dpdk.org; Xu, Qian Q <qian.q.xu at intel.com>; Liu, Yong <yong.liu at intel.com>
Subject: Re: [dpdk-ci] [PATCH v4 7/7] tests: add checkpatch

Hi Fangfang,

2016-12-06 06:34, Wei, FangfangX:
> Hi Thomas,
> 
> Here are some questiones about your scripts:
> 
> 1. With the script "send-patch-report.sh", Can I send my perpatch build results to patchwork as checkpatch result in patchwork?
> 
> Such as, generate the GUI as blow:
> 
> [cid:image001.png at 01D24FCC.01E4A4D0]

Yes, your report will be properly integrated into patchwork if you use send-patch-report.sh.

> 2. Must I create /etc/dpdk/ci.config before using your scripts?

No it is not required.

>    Because when I run it, it prompted following error message:
>    /root/dpdk-cii/tools/load-ci-config.sh: line 5: /etc/dpdk/ci.config: No such file or directory
>    /root/dpdk-cii/tools/load-ci-config.sh: line 6: 
> /etc/dpdk/ci.config: No such file or directory

It is strange. This configuration file is read only if it exists:
	test ! -r /etc/dpdk/ci.config || . /etc/dpdk/ci.config

> 3. Some confuse about the parameters in "send-patch-report.sh":
> 
>            options:
>                 -t title    subject of the patch email
>                 -f from     sender of the patch email
>                 -m msgid    id of the patch email
>                 -p listid   mailing list publishing the patch

These 4 options can be filled with the help of parse-email.sh.

>                 -l label    title of the test
>                 -s status   one of these test results: SUCCESS, WARNING, FAILURE
>                 -d desc     few words to better describe the status
> 
> For example, about patch 
> http://www.dpdk.org/dev/patchwork/patch/17673/
> 
> -t title    subject of the patch email
>    Is it "[dpdk-dev,2/8] drivers/common/dpaa2: Sample descriptors for NXP DPAA2 SEC operations."?

It should be the original subject from the email, not the one converted by patchwork (as above):
	[dpdk-dev] [PATCH 2/8] drivers/common/dpaa2: Sample descriptors for NXP DPAA2 SEC operations.

> -f from     sender of the patch email
>    Is it the author who send the patch? In patch 17673, is it akhil.goyal at nxp.com<mailto:akhil.goyal at nxp.com>?

Not exactly. You should refer to the original mail:
	Akhil Goyal <akhil.goyal at nxp.com>

> -m msgid    id of the patch email
>    Is it the message-id of this patch? In patch 17673, is it 20161205125540.6419-3-akhil.goyal at nxp.com<mailto:20161205125540.6419-3-akhil.goyal at nxp.com>?

No it is <20161205125540.6419-3-akhil.goyal at nxp.com>

> -p listid   mailing list publishing the patch
>    Is it the receiver about this patch? In patch 17673, is it dev at dpdk.org<mailto:dev at dpdk.org>?

No, it is the List-Id header:
	DPDK patches and discussions <dev.dpdk.org>

> I try to send my result with script "send-patch-report.sh" with below command, but nothing happened.
> 
> echo "$report" | /root/dpdk-cii/tools/send-patch-report.sh -t "[dpdk-dev,2/8] drivers/common/dpaa2: Sample descriptors for NXP DPAA2 SEC operations." -f "akhil.goyal at nxp.com" -m "20161205125540.6419-3-akhil.goyal at nxp.com" -p "dev at dpdk.org" -l "Intel Per-patch compilation check" -s "SUCCESS" -d "Compilation OK"

The list-id is wrong so it was detected as a private patch.
It has probably sent a private report to Akhil.

I think your issue is to get the original email.
If I understand well, you are getting the patch from patchwork.
If you want to continue getting the patch from patchwork, you must use this URL:
	http://www.dpdk.org/dev/patchwork/patch/17673/mbox/
and fake listid and from.
For the listid, you can use -p dev.dpdk.org For the from, you must convert [dpdk-dev,v2,1/4] to [dpdk-dev] [PATCH v2 1/4] or just [PATCH v2 1/4] (without [dpdk-dev]) would be sufficient.

For the checkpatch example, it fetches emails from patchwork at dpdk.org mailbox which is registered in the dev mailing list.


More information about the ci mailing list