[dpdk-ci] [PATCH v4 7/7] tests: add checkpatch

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Dec 12 10:39:31 CET 2016


2016-12-12 09:27, Wei, FangfangX:
> 
> 2016-12-09 08:51, Wei, FangfangX:
> >> My internet connection is working fine, and also configure http_proxy and https_proxy, but the connection is still timeout.
> >> 
> >> I think that's because the rpc client can't connect to your rpc server. Is there any other configuration should be configured?
> 
> >I've found it is an open issue. pwclient does not work with proxy:
> >	https://github.com/getpatchwork/patchwork/issues/47
> 
> With John's patch, pwclient is working via intel firewall now.
> Thanks, John!

I've submitted a generic proxy support to patchwork:
	https://patchwork.ozlabs.org/patch/704687/
	https://patchwork.ozlabs.org/patch/704688/

> >> According to my understanding, the "pwid=$($pwclient list -f '%{id}' -m "$msgid " in the script "send-patch-report.sh" is just trying to get the patchwork id, is that right?
> 
> >Yes, if you already have to patchwork id, you can put it.
> >It makes me think that the patchwork id should be an option of this script.
> 
> I think adding patchwork id as an option of this script is a good idea.
> Because in my per-patch build report, the patchwork id is known. There's no necessary to get it through patchwork with message id.

It will be in the next revision of this patchset.

> >> Then I just define pwid="17772" in "send-patch-report.sh" directly, run the script again, nothing happened. The email hasn't been sent to test-report at dpdk.org.
> 
> >Are you sure "sendmail -t" is working fine in your environment?
> 
> Actually, I'm not sure about it. In your environment, is there any configuration about sendmail in Linux?

Nothing special.

> >> I think the function about send-patch-report.sh is just to send patch report to test-report at dpdk.org. It can't generate the following content in patchwork as checkpatch. Am I right?
> 
> >Yes it just an email to test-report at dpdk.org. Then this email is automatically parsed and integrated in patchwork by update-pw.sh running on the server.
> >That's how the checkpatch test works (see tests/checkpatch.sh).
> 
> If I send email with my own script, the receiver is test-report at dpdk.org, and the report format shows as below. Is this email also automatically parsed and integrated in patchwork on the server?
> 
> Test-Label: Intel Per-patch compilation check
> Test-Status: SUCCESS
> http://dpdk.org/patch/17859
> 
> _Compilation OK_
> 
> The content about this compilation

Yes it would work.
What are you using to send this email?
I'd like to understand why sendmail does not work for you.


More information about the ci mailing list