<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> Hi Thomas,<o:p></o:p> <o:p> </o:p> Here are some questiones about your scripts:<o:p></o:p> 1. With the script "send-patch-report.sh", Can I send my perpatch build results to patchwork as checkpatch result in patchwork?<o:p></o:p> Such as, generate the GUI as blow:<o:p></o:p> <img width="384" height="153" id="Picture_x0020_2" src="cid:image001.png@01D24FCC.01E4A4D0"><o:p></o:p> 2. Must I create /etc/dpdk/ci.config before using your scripts?<o:p></o:p> Because when I run it, it prompted following error message:<o:p></o:p> /root/dpdk-cii/tools/load-ci-config.sh: line 5: /etc/dpdk/ci.config: No such file or directory<o:p></o:p> /root/dpdk-cii/tools/load-ci-config.sh: line 6: /etc/dpdk/ci.config: No such file or directory<o:p></o:p> <o:p> </o:p> 3. Some confuse about the parameters in "send-patch-report.sh":<o:p></o:p> options:<o:p></o:p> -t title subject of the patch email<o:p></o:p> -f from sender of the patch email<o:p></o:p> -m msgid id of the patch email<o:p></o:p> -p listid mailing list publishing the patch<o:p></o:p> -l label title of the test<o:p></o:p> -s status one of these test results: SUCCESS, WARNING, FAILURE<o:p></o:p> -d desc few words to better describe the status<o:p></o:p> <o:p> </o:p> For example, about patch <a href="http://www.dpdk.org/dev/patchwork/patch/17673/"> http://www.dpdk.org/dev/patchwork/patch/17673/</a><o:p></o:p> -t title subject of the patch email<o:p></o:p> Is it “[dpdk-dev,2/8] drivers/common/dpaa2: Sample descriptors for NXP DPAA2 SEC operations.”?<o:p></o:p> -f from sender of the patch email<o:p></o:p> Is it the author who send the patch? In patch 17673, is it <a href="mailto:akhil.goyal@nxp.com">akhil.goyal@nxp.com</a>?<o:p></o:p> -m msgid id of the patch email<o:p></o:p> Is it the message-id of this patch? In patch 17673, is it <a href="mailto:20161205125540.6419-3-akhil.goyal@nxp.com">20161205125540.6419-3-akhil.goyal@nxp.com</a>?<o:p></o:p> -p listid mailing list publishing the patch<o:p></o:p> Is it the receiver about this patch? In patch 17673, is it <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>?<o:p></o:p> <o:p> </o:p> I try to send my result with script “send-patch-report.sh” with below command, but nothing happened.<o:p></o:p> echo "$report" | /root/dpdk-cii/tools/send-patch-report.sh -t "[dpdk-dev,2/8] drivers/common/dpaa2: Sample descriptors for NXP DPAA2 SEC operations." -f "akhil.goyal@nxp.com" -m "20161205125540.6419-3-akhil.goyal@nxp.com" -p "dev@dpdk.org" -l "Intel Per-patch compilation check" -s "SUCCESS" -d "Compilation OK"<o:p></o:p> <o:p> </o:p> <o:p> </o:p> Best Regards<o:p></o:p> Fangfang<o:p></o:p> <o:p> </o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <a name="_____replyseparator"></a>-----Original Message----- From: ci [mailto:ci-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, December 5, 2016 9:26 PM To: ci@dpdk.org Subject: [dpdk-ci] [PATCH v4 7/7] tests: add checkpatch <o:p> </o:p> This is the first test in this repository.<o:p></o:p> It runs on dpdk.org and use checkpatch.pl of Linux.<o:p></o:p> <o:p> </o:p> Note that the patch is not applied on a git tree for this basic test.<o:p></o:p> <o:p> </o:p> Signed-off-by: Thomas Monjalon <<a href="mailto:thomas.monjalon@6wind.com">thomas.monjalon@6wind.com</a>><o:p></o:p> ---<o:p></o:p> tests/checkpatch.sh | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++<o:p></o:p> 1 file changed, 70 insertions(+)<o:p></o:p> create mode 100755 tests/checkpatch.sh<o:p></o:p> <o:p> </o:p> diff --git a/tests/checkpatch.sh b/tests/checkpatch.sh new file mode 100755 index 0000000..319da1e<o:p></o:p> --- /dev/null<o:p></o:p> +++ b/tests/checkpatch.sh<o:p></o:p> @@ -0,0 +1,70 @@<o:p></o:p> +#! /bin/sh -e<o:p></o:p> +<o:p></o:p> +# BSD LICENSE<o:p></o:p> +#<o:p></o:p> +# Copyright 2016 6WIND S.A.<o:p></o:p> +#<o:p></o:p> +# Redistribution and use in source and binary forms, with or without # <o:p></o:p> +modification, are permitted provided that the following conditions # <o:p></o:p> +are met:<o:p></o:p> +#<o:p></o:p> +# * Redistributions of source code must retain the above copyright<o:p></o:p> +# notice, this list of conditions and the following disclaimer.<o:p></o:p> +# * Redistributions in binary form must reproduce the above copyright<o:p></o:p> +# notice, this list of conditions and the following disclaimer in<o:p></o:p> +# the documentation and/or other materials provided with the<o:p></o:p> +# distribution.<o:p></o:p> +# * Neither the name of 6WIND S.A. nor the names of its<o:p></o:p> +# contributors may be used to endorse or promote products derived<o:p></o:p> +# from this software without specific prior written permission.<o:p></o:p> +#<o:p></o:p> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS # <o:p></o:p> +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT # <o:p></o:p> +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR # <o:p></o:p> +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT # <o:p></o:p> +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, # <o:p></o:p> +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT # <o:p></o:p> +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, # <o:p></o:p> +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY # <o:p></o:p> +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT # <o:p></o:p> +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # <o:p></o:p> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.<o:p></o:p> +<o:p></o:p> +print_usage () {<o:p></o:p> + cat <<- END_OF_HELP<o:p></o:p> + usage: $(basename $0) dpdk_dir < email<o:p></o:p> +<o:p></o:p> + Check email-formatted patch from stdin.<o:p></o:p> + This test runs checkpatch.pl of Linux via a script in dpdk_dir.<o:p></o:p> + END_OF_HELP<o:p></o:p> +}<o:p></o:p> +<o:p></o:p> +while getopts h arg ; do<o:p></o:p> + case $arg in<o:p></o:p> + h ) print_usage ; exit 0 ;;<o:p></o:p> + ? ) print_usage >&2 ; exit 1 ;;<o:p></o:p> + esac<o:p></o:p> +done<o:p></o:p> +shift $(($OPTIND - 1))<o:p></o:p> +toolsdir=$(dirname $(readlink -m $0))/../tools<o:p></o:p> +dpdkdir=$1<o:p></o:p> +<o:p></o:p> +email=/tmp/$(basename $0 sh)$$<o:p></o:p> +$toolsdir/filter-patch-email.sh >$email trap "rm -f $email" INT EXIT<o:p></o:p> +<o:p></o:p> +eval $($toolsdir/parse-email.sh $email) # normal exit if no valid patch <o:p></o:p> +in the email [ -n "$subject" -a -n "$from" ] || exit 0<o:p></o:p> +<o:p></o:p> +failed=false<o:p></o:p> +report=$($dpdkdir/scripts/checkpatches.sh -q $email) || failed=true <o:p></o:p> +report=$(echo "$report" | sed '1,/^###/d')<o:p></o:p> +<o:p></o:p> +label='checkpatch'<o:p></o:p> +$failed && status='WARNING' || status='SUCCESS'<o:p></o:p> +$failed && desc='coding style issues' || desc='coding style OK'<o:p></o:p> +<o:p></o:p> +echo "$report" | $toolsdir/send-patch-report.sh \<o:p></o:p> + -t "$subject" -f "$from" -m "$msgid" -p "$listid" \<o:p></o:p> + -l "$label" -s "$status" -d "$desc"<o:p></o:p> --<o:p></o:p> 2.7.0<o:p></o:p> <o:p> </o:p> </div> </body> </html>