[dpdk-dev] [PATCH] pci: fix probing blacklisted device with RTE_PCI_DRV_MULTIPLE flag

Julien Courtat julien.courtat at 6wind.com
Tue Apr 16 10:31:48 CEST 2013


When blacklisting network adapters that share a PCI bus address with multiple
ports such as Mellanox ConnectX-3 (librte_pmd_mlx4), RTE applications
enter infinite loops while probing PCI devices.

This commit removes this probe on subsequent instances for blacklisted devices
that have RTE_PCI_DRV_MULTIPLE set.

Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
Signed-off-by: Julien Courtat <julien.courtat at 6wind.com>
---
 lib/librte_eal/common/eal_common_pci.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 3a6ab70..4e1a944 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -91,9 +91,11 @@ pci_probe_all_drivers(struct rte_pci_device *dev)
 		if (rte_eal_pci_probe_one_driver(dr, dev))
 			continue;
 		/* initialize subsequent driver instances for this device */
-		if (dr->drv_flags & RTE_PCI_DRV_MULTIPLE)
+		if ((dr->drv_flags & RTE_PCI_DRV_MULTIPLE) &&
+		    (!dev->blacklisted)) {
 			while (rte_eal_pci_probe_one_driver(dr, dev) == 0)
 				;
+		}
 		return 0;
 	}
 	return -1;
-- 
1.7.2.5




More information about the dev mailing list