[dpdk-dev] [PATCH] config: fix combined/shared lib
Olivier MATZ
olivier.matz at 6wind.com
Wed Oct 30 09:53:04 CET 2013
Hi Thomas,
> - Configuration for combined and shared library was only in
> the template defconfig_x86_64-default-linuxapp-gcc.
> - CONFIG_RTE_LIBNAME was in the wrong section
> - CONFIG_RTE_LIBNAME quotes were not properly removed in "make context"
> - RTE_LIBNAME had no quote in "C context" (include/rte_config.h)
acked
Just one remark about the commit log: if I understand well, the
issue related to the quote not properly removed in "make context"
is triggered by the quotes you added in the defconfig. I would reword
the commit log a bit to highlight it.
Regards,
Olivier
More information about the dev
mailing list