[dpdk-dev] [PATCH 4/4] app: fix build with gcc 4.8
Nicolas Dichtel
nicolas.dichtel at 6wind.com
Thu Sep 12 17:59:13 CEST 2013
Le 29/07/2013 14:44, Thomas Monjalon a écrit :
> GCC 4.8 was producing this error:
> argument to ‘sizeof’ in ‘strncmp’ call is the same expression as the
> second source; did you mean to provide an explicit length?
> [-Werror=sizeof-pointer-memaccess]
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> ---
> app/test/test_cmdline_string.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_cmdline_string.c b/app/test/test_cmdline_string.c
> index 7b358cf..84a82ce 100644
> --- a/app/test/test_cmdline_string.c
> +++ b/app/test/test_cmdline_string.c
> @@ -383,7 +383,7 @@ test_parse_string_valid(void)
> return -1;
> }
> if (strncmp(buf, string_elt_strs[i].result,
> - sizeof(string_elt_strs[i].result)) != 0) {
> + sizeof(buf)) != 0) {
In fact, it seems you can use strcmp() instead of strncmp(). Or, if the
intention was really to check the length, use strlen(), but this one will not
include the last '\0'.
More information about the dev
mailing list