[dpdk-dev] [RFC PATCH 03/14] mbuf: remove the rte_pktmbuf structure

Olivier MATZ olivier.matz at 6wind.com
Tue Aug 12 10:38:31 CEST 2014


Hi Bruce,

On 08/11/2014 10:44 PM, Bruce Richardson wrote:
> From: Olivier Matz <olivier.matz at 6wind.com>
>
> The rte_pktmbuf structure was initially included in the rte_mbuf
> structure. This was needed when there was 2 types of mbuf (ctrl and
> packet). As the control mbuf has been removed, we can merge the
> rte_pktmbuf into the rte_mbuf structure.
>
> Advantages of doing this:
>    - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data)
>    - make the structure more consistent: for instance, there was no reason
>      to have the ol_flags field in rte_mbuf
>    - it will allow a deeper reorganization of the rte_mbuf structure in the
>      next commits, allowing to gain several bytes in it
>
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>
> Conflicts:
> 	lib/librte_pmd_virtio/virtio_rxtx.c
> 	lib/librte_pmd_virtio/virtqueue.h
> 	lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>

Some files are missing. We can find some with: git grep "pkt\." in
app/test/packet_burst_generator.c
examples/ip_fragmentation/main.c
examples/ip_pipeline/pipeline_rx.c
examples/ip_pipeline/pipeline_tx.c
lib/librte_port/rte_port_frag.c

I'm not sure it gives all remaining occurences. The best way
to find them is probably to check the compilation of examples
for all targets.


Olivier



More information about the dev mailing list