[dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly

Stephen Hemminger stephen at networkplumber.org
Tue Aug 26 02:33:59 CEST 2014


On Fri, 01 Aug 2014 16:50:06 +0200
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:

> 2014-07-25 10:50, Stephen Hemminger:
> > The driver must listen to broadcast packets, like other devices.
> > Otherwise protocols like ARP won't work!
> > 
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> 
> > -	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > +	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> 
> It's also removing multicast at init. No comment so I assume everybody agrees.
> 
> Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> 
> Applied for version 1.7.1.
> 
> Thanks

My general rule is to make all drivers behave the same.
In DPDK, the ixgbe driver is the "best known" reference.
In that driver "multicast promiscious" is disabled by default.


More information about the dev mailing list