[dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Aug 26 08:50:15 CEST 2014


2014-08-25 17:33, Stephen Hemminger:
> Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> > 2014-07-25 10:50, Stephen Hemminger:
> > > -	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1);
> > > +	vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> > 
> > It's also removing multicast at init. No comment so I assume everybody agrees.
> 
> My general rule is to make all drivers behave the same.

I think it's a good rule :)

> In DPDK, the ixgbe driver is the "best known" reference.
> In that driver "multicast promiscious" is disabled by default.

OK, thanks.
-- 
Thomas


More information about the dev mailing list