[dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification

[Liu, Jijiang]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, August 27, 2014 10:59 PM
> To: Liu, Jijiang
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet
> identification
> 
> Hi Jijiang,
> 
> 2014-08-26 15:31, Jijiang Liu:
> > VxLAN UDP port configuration on i40e, which include
> >  -  VxLAN UDP port initialization
> >  -  add APIs to configure VxLAN UDP port
> 
> Actually you should explain that you introduce tunnels and first one is VxLAN.
> 
> >  lib/librte_ether/rte_ethdev.c     |   63 ++++++++++++
> >  lib/librte_ether/rte_ethdev.h     |   76 ++++++++++++++
> >  lib/librte_ether/rte_ether.h      |   10 ++
> >  lib/librte_pmd_i40e/i40e_ethdev.c |  199
> ++++++++++++++++++++++++++++++++++++-
> >  lib/librte_pmd_i40e/i40e_ethdev.h |    5 +
> 
> Changing ethdev API is so sensible that it deserves a separated commit.
> 
> Code seems OK.
> 
You meant that I should split the patch into two patches, one is for changes in librte_ether, other is for 
Change in librte_pmd_i40e? Or one for VxLAN UDP port initialization, other is for add APIs to configure VxLAN UDP port?

--
Jijiang Liu