[dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Aug 28 13:00:33 CEST 2014


2014-08-28 09:01, Wu, Jingjing:
> I have another question:
> If we use the way 'rx_classification_filter_ctl' works, the specific
> structures defined in rte_i40e.h will be visible in user's application,
> such as testpmd.
> I know I shouldn't make commands linked with i40e like what I did before.
> But will the i40e specific structures become visible be acceptable?

I think testpmd should be limited to generic API.
So it wouldn't be acceptable to be dependent of i40e files.
But having some specific i40e tests in examples or app/test is OK.

-- 
Thomas


More information about the dev mailing list