[dpdk-dev] [PATCH v2 27/28] eal/pci: Remove rte_eal_dev_attach/detach_pdev() and rte_eal_dev_attach/detach_vdev()

Tetsuya Mukawa mukawa at igel.co.jp
Tue Dec 9 04:42:50 CET 2014


These functions are wrapped by rte_eal_dev_attach/detach(). So delete
these.

Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp>
---
 lib/librte_eal/common/eal_common_dev.c  |  8 +++---
 lib/librte_eal/common/include/rte_dev.h | 50 ---------------------------------
 2 files changed, 4 insertions(+), 54 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index c9d4894..7481fb7 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -174,7 +174,7 @@ rte_eal_dev_find_and_invoke(const char *name, int type)
 }
 
 /* attach the new physical device, then store port_id of the device */
-int
+static int
 rte_eal_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id)
 {
 	uint8_t new_port_id;
@@ -203,7 +203,7 @@ err:
 }
 
 /* detach the new physical device, then store pci_addr of the device */
-int
+static int
 rte_eal_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr)
 {
 	struct rte_pci_addr freed_addr;
@@ -252,7 +252,7 @@ get_vdev_name(char *vdevargs)
 }
 
 /* attach the new virtual device, then store port_id of the device */
-int
+static int
 rte_eal_dev_attach_vdev(const char *vdevargs, uint8_t *port_id)
 {
 	char *args;
@@ -294,7 +294,7 @@ err0:
 }
 
 /* detach the new virtual device, then store the name of the device */
-int
+static int
 rte_eal_dev_detach_vdev(uint8_t port_id, char *vdevname)
 {
 	char name[RTE_ETH_NAME_MAX_LEN];
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index 1f8f24a..9da518d 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -102,56 +102,6 @@ void rte_eal_driver_unregister(struct rte_driver *driver);
 #if defined(RTE_LIBRTE_EAL_HOTPLUG) && defined(RTE_LIBRTE_EAL_LINUXAPP)
 
 /**
- * Attach a new physical device.
- *
- * @param addr
- *   A pointer to a pci address structure describing the new
- *   device to be attached.
- * @param port_id
- *  A pointer to a port identifier actually attached.
- * @return
- *  0 on success and port_id is filled, negative on error
- */
-int rte_eal_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id);
-
-/**
- * Attach a new virtual device.
- *
- * @param vdevargs
- *   A pointer to a strings array describing the new device
- *   to be attached.
- * @param port_id
- *  A pointer to a port identifier actually attached.
- * @return
- *  0 on success and port_id is filled, negative on error
- */
-int rte_eal_dev_attach_vdev(const char *vdevargs, uint8_t *port_id);
-
-/**
- * Detach a physical device.
- *
- * @param port_id
- *   The port identifier of the physical device to detach.
- * @param addr
- *  A pointer to a pci address structure actually detached.
- * @return
- *  0 on success and addr is filled, negative on error
- */
-int rte_eal_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr);
-
-/**
- * Detach a virtual device.
- *
- * @param port_id
- *   The port identifier of the virtual device to detach.
- * @param addr
- *  A pointer to a virtual device name actually detached.
- * @return
- *  0 on success and vdevname is filled, negative on error
- */
-int rte_eal_dev_detach_vdev(uint8_t port_id, char *vdevname);
-
-/**
  * Attach a new device.
  *
  * @param devargs
-- 
1.9.1



More information about the dev mailing list