[dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API

Wu, Jingjing jingjing.wu at intel.com
Thu Dec 25 04:39:04 CET 2014


Hi, Michael

It's a long discuss in community.

Due to in the development in i40e driver, we defined a new common API used for kinds of filters. In R1.8, because of time limit and compatibility, we just used the new API for i40e driver. While other driver still use old ones.
We have planned to integrate filter to this new API to make the APIs generic for different types of NICs.

Jingjing


> -----Original Message-----
> From: Qiu, Michael
> Sent: Thursday, December 25, 2014 11:27 AM
> To: Wu, Jingjing; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe
> driver to new API
> 
> Hi Jingjing,
> 
> Would you mind to tell me why need new APIs? Any functional or
> performance increase?
> Better to state in commit log.
> 
> You know it should be careful to change APIs, especially for user interface.
> 
> Thanks,
> Michael
> On 12/25/2014 11:14 AM, Jingjing Wu wrote:
> > The patch set uses new filter_ctrl API to replace old ethertype filter APIs.
> > It uses new functions and structure to replace old ones in igb/ixgbe
> > driver, new commands to replace old ones in testpmd, and removes the
> old APIs.
> >
> > Jingjing Wu (4):
> >   ixgbe: new functions replaces old ones for ethertype filters
> >   e1000: new functions replaces old ones for ethertype filters
> >   testpmd: new commands for ethertype filter
> >   ethdev: remove old APIs and structures of ethertype filters
> >
> >  app/test-pmd/cmdline.c              | 253 ++++++++++++--------------
> >  app/test-pmd/config.c               |  27 ---
> >  lib/librte_ether/rte_ethdev.c       |  57 ------
> >  lib/librte_ether/rte_ethdev.h       |  88 ---------
> >  lib/librte_pmd_e1000/e1000_ethdev.h |  13 ++
> >  lib/librte_pmd_e1000/igb_ethdev.c   | 332 +++++++++++++++++++++-----
> -------
> >  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 354
> > +++++++++++++++++++++++-------------
> >  lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  13 ++
> >  8 files changed, 579 insertions(+), 558 deletions(-)
> >



More information about the dev mailing list