[dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices

Thomas Monjalon thomas.monjalon at 6wind.com
Sat Jul 12 00:30:34 CEST 2014


About the form of the patch, I have 2 comments:

1) A doc explaining the design, the dependencies and how it can be used would 
be a great help. Could you write it in rst format?

2) checkpatch.pl returns these errors:

ERROR:SPACING: space required before the open parenthesis '('
#468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
+               if(sockfd != -1)

ERROR:SPACING: space required before the open parenthesis '('
#471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
+               if(sockfd != -1)

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
+               ifr.ifr_name[ifnamelen]='\0';

Thanks
-- 
Thomas


More information about the dev mailing list