[dpdk-dev] [PATCH v2] kni: use netif_rx instead of netif_receive_skb in which ocurr deallock on userpace contex
Thomas Monjalon
thomas.monjalon at 6wind.com
Thu Jul 17 14:02:16 CEST 2014
Hi,
2014-07-11 23:37, Yao-Po Wang:
> Per netif_receive_skb function description, it may only be called from
> interrupt contex, but KNI is run on kthread that like as user-space
> contex. It may occur deallock, if netif_receive_skb called from kthread,
> so it should be repleaced by netif_rx or adding local_bh_disable/enable
> around netif_receive_skb.
>
> Signed-off-by: Yao-Po Wang <blue119 at gmail.com>
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> /* Call netif interface */
> - netif_receive_skb(skb);
> + netif_rx(skb);
Is there someone confident to approve this change?
--
Thomas
More information about the dev
mailing list