[dpdk-dev] [PATCH v3] mk: allow updates to build config on make install

[Olivier MATZ]

Hi Thomas,

On 06/10/2014 03:51 PM, Thomas Monjalon wrote:
> +		if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \
> +			tmp_build=/tmp/dpdk-$*-$$$$; \
> +			$(MAKE) config T=$* O=$$(tmp_build); \
> +			if ! cmp -s $(BUILD_DIR)/$*/.config.orig $$(tmp_build)/.config ; then \
> +				echo "Conflict: local config and template config have both changed"; \
> +				exit 1; \

I missed it the first time, but what do you think about using
$(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ?
I think using /tmp should be avoided when possible as it is a
shared folder.

Regards,
Olivier