[dpdk-dev] [PATCH v2 1/4] Link Bonding Library

Doherty, Declan declan.doherty at intel.com
Fri Jun 13 16:03:22 CEST 2014


> -----Original Message-----
> From: Eric Kinzie [mailto:ehkinzie at gmail.com]
> Sent: Monday, June 9, 2014 10:11 PM
> To: Doherty, Declan
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] Link Bonding Library
> 
> On Wed Jun 04 16:18:53 +0100 2014, Declan Doherty wrote:
> > - Broadcast TX burst broadcast bug fix
> > - Add/remove slave behavior fix
> > - Checkpatch fixes
> 
> Declan, would you consider the following change to rte_bond.c?  The two
> header files from librte_cmdline don't seem to be necessary.
> 
>  Eric
> 
> 
> --- a/lib/librte_bond/rte_bond.c
> +++ b/lib/librte_bond/rte_bond.c
> @@ -44,9 +44,6 @@
>  #include <rte_ip.h>
>  #include <rte_udp.h>
> 
> -#include <cmdline_parse.h>
> -#include <cmdline_parse_etheraddr.h>
> -
>  #include "rte_bond.h"
> 
>  static const char *driver_name = "Link Bonding PMD";

Hi Eric, 
I've cleaned up the includes in v3 of the patch, but the those headers are now actually required for the kvarg parsing.

Regards
Declan


More information about the dev mailing list