[dpdk-dev] [PATCH v2 0/4] Link Bonding Library

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Jun 13 17:15:28 CEST 2014


2014-06-13 14:08, Doherty, Declan:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Do you think you can send another version of your serie soon?
> > Some comments need to be addressed.
> > 
> > 2 formatting comments:
> > - I saw some strange alignments of comments
> > - you should send your patches as children of the cover letter
> 
> Hi Thomas, 
> I've just submitted v3 of the patch, which should address the majority of the comments and any formatting issues.

Thanks. We are now waiting for Neil's acknowledgement.

On the formatting side, please check these errors:
	ERROR: "foo* bar" should be "foo *bar"
	ERROR: space prohibited before that close parenthesis ')'

About git-send-email, I'd prefer you conform to this scheme for man page:
"
  So for example when --thread and --no-chain-reply-to are specified, the second and subsequent
  patches will be replies to the first one like in the illustration below where [PATCH v2 0/3] is in
  reply to [PATCH 0/2]:

    [PATCH 0/2] Here is what I did...
      [PATCH 1/2] Clean up and tests
      [PATCH 2/2] Implementation
      [PATCH v2 0/3] Here is a reroll
        [PATCH v2 1/3] Clean up
        [PATCH v2 2/3] New tests
        [PATCH v2 3/3] Implementation
"

Thanks
-- 
Thomas


More information about the dev mailing list