[dpdk-dev] [PATCH v2 00/27] Add i40e PMD support

Zhang, Helin helin.zhang at intel.com
Wed Jun 18 10:51:02 CEST 2014



-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] 
Sent: Wednesday, June 18, 2014 12:28 AM
To: Zhang, Helin; Chen, Jing D
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support

> The 2nd version of series of patches are to add i40e PMD support.
> It contains the updated basic shared code, and some other enhancements.
> It adds the support of the latest version of firmware.
> * Add new PMD driver of i40e in the folder of librte_pmd_i40e
> * Add some neccessary definitions, changes in rte_mbuf.h and eth_dev
> * Add new configurations for i40e
> * Add or modifiy makefiles to support i40e compilation
> * Add neccessary changes in ixgbe, e1000 and vmxnet3 PMD, as hash flags
>   has been enlarged from 16 bits to 64 bits to support i40e
> * Add neccessary changes in example applications and testpmd to use
>   ETH_RSS_IP to replace all IP hash flags, as i40e introduced more
>   hash flags.
> * Add command in testpmd for port based vlan insertion offload testing
> * Add neccessary changes in eth_dev to support configuring maximum
>   packet length of less than 1518
> * Add two sys files in igb_uio to support enabling/disabling
>   'Extended Tag' and resetting 'Max Read Request Size', as it has
>   big impacts on i40e performance
> * Add neccessary changes in pci to read/write the above two sys files
>   during probing PCI
> 
> Features/enhancements to be implemented later:
> * Set link speed, and physically up/down
> * Double VLAN support, flow director, VMDq and DCB
> * VLAN insertion/stripping, RSS in VF
> 
> Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> Signed-off-by: Jing Chen <jing.d.chen at intel.com>
> Acked-by: Cunming Liang <cunming.liang at intel.com>
> Acked-by: Jijiang Liu <jijiang.liu at intel.com>
> Acked-by: Jingjing Wu <jingjing.wu at intel.com>
> Acked-by: Heqing Zhu <heqing.zhu at intel.com>
> Tested-by: Waterman Cao <waterman.cao at intel.com>

Applied for version 1.7.0.

Some things could be cleaned up later, especially i40e specific flags in generic API must be removed. Please work on a patch for next release.

Thanks for the hard work
--
Thomas

------------------------------------------------------------------------------------

Hi Thomas

Thank you greatly to merge those code!

Btw, what do you mean the i40e specific flags in generic API? Did you mean the new flags defined in rte_mbuf.h?
Yes, we are working on some bug fixes and enhancements which might need to be added in the next release. Hopefully we can see them soon.

Regards,
Helin


More information about the dev mailing list