[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

Richardson, Bruce bruce.richardson at intel.com
Tue Jun 24 19:39:52 CEST 2014


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, June 24, 2014 9:03 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
> 
> The function rte_snprintf serves no useful purpose. It is the
> same as snprintf() for all valid inputs. Just remove it and
> replace all uses in current code.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> 

NAK to this as is.
Approve of replacing all instance of the rte_snprintf function with the standard version in all our code and libraries.
However, rather than just removing the function completely, I think we should just flag the function as deprecated initially, and then later on look to remove it completely.

/Bruce


More information about the dev mailing list