[dpdk-dev] [PATCH] mempool: don't leak ring on failure

Olivier MATZ olivier.matz at 6wind.com
Wed Jun 25 10:01:51 CEST 2014


On 06/25/2014 09:46 AM, Olivier MATZ wrote:
> Your patch moves the creation of the ring after the call to
> rte_memzone_reserve(), so now it tries to create the memory
> for the object pool before the ring. The problem disappears
> because the object pool is usually much bigger than the ring,
> so once the first allocation is done, the second is unlikely
> to fail.
>
> I think this explanation could be added in the commit log.
>
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

Sorry, I didn't see that Konstantin and Bruce already answered to
this.




More information about the dev mailing list