[dpdk-dev] [PATCH v11 1/5] bond: new link bonding library

[Thomas Monjalon]

Hi Declan,

2014-06-29 18:49, Declan Doherty:
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -205,6 +205,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
>  LDLIBS += -lrte_pmd_pcap -lpcap
>  endif
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)
> +LDLIBS += -lrte_pmd_bond
> +endif
> +
>  endif

This part is linking bonding library only in case of static libraries.
But this library has a specific API. So it cannot be a plugin and must always 
be linked. That's why I suggested to split the library.
Instead, I suggest to always link with bonding library. See my proposal below:

--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -175,7 +175,12 @@ LDLIBS += -lrte_pmd_xenvirt
 LDLIBS += -lxenstore
 endif
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)
+LDLIBS += -lrte_pmd_bond
+endif
+
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
+# plugins (link only if static libraries)
 
 ifeq ($(CONFIG_RTE_LIBRTE_VMXNET3_PMD),y)
 LDLIBS += -lrte_pmd_vmxnet3_uio
@@ -205,7 +210,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
 LDLIBS += -lrte_pmd_pcap -lpcap
 endif
 
-endif
+endif # plugins (link only if static libraries)


Adding comments to explain plugin section will be clearer.

-- 
Thomas