[dpdk-dev] [PATCH v11 0/5] link bonding library

Doherty, Declan declan.doherty at intel.com
Mon Jun 30 11:28:16 CEST 2014


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, June 30, 2014 10:21 AM
> To: Doherty, Declan
> Cc: dev at dpdk.org
> Subject: Re: [PATCH v11 0/5] link bonding library
> 
> Hi Declan,
> 
> 2014-06-29 18:49, Declan Doherty:
> > This patchset contains the name change fix in the link bonding library
> > makefile. I have also put a change into the unit test application makefile
> > so that the link bonding tests are not built if the library is also not
> > being built. It doesn't make sense to split the bonding libraries APIs into
> > a seperate library, as they are directly coupled to with the bonding
> > library implmentation
> 
> You fixed optional building but there is still an issue when building shared
> library.
> As you don't want to split the library to separate the PMD plugin from the
> specific API, I suggest to not consider it as a plugin (unlike other PMDs).
> 
> I've sent some patches about these 2 topics.
> If you agree, I'll apply them, merged with your serie.
> 
> Thanks
> --
> Thomas

Hi Thomas,
I'm happy for you to apply the makefile changes you have suggested and not 
consider the bonding PMD as a plugin, I  think this makes the most sense
considering it is a purely software library. 

Thanks
Declan


More information about the dev mailing list