[dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev

Richardson, Bruce bruce.richardson at intel.com
Tue Mar 4 14:14:17 CET 2014


> 
> My initial concern was that --use-device has 2 different significations,
> depending on the format of arguments:
>    - instanciate a virtual driver if it looks like a vdev name
>    - add a PCI device to the whitelist if it looks like a pci address I also find
> strange that instanciating a virtual device changes the PCI mode to
> whitelist, even if it could be fixed by adding a specific argument for that.
> 
[BR] I agree that having the mode change silently like that was probably not the best design. I therefore, agree that a flag should be used to switch from normal to whitelist mode, I just think that thereafter the devices of whatever type should all be enumerated using a common flag parameter.

> Splitting into two different options looked clearer to me, but this is of
> course not a blocking issue for me.
> 
[BR] For me neither, just giving my 2c worth :-).



More information about the dev mailing list