[dpdk-dev] [PATCH] Don't inline string functions

Thomas Monjalon thomas.monjalon at 6wind.com
Wed May 14 17:47:01 CEST 2014


2014-05-14 08:19, Stephen Hemminger:
> It makes no sense to inline string functions, in fact snprintf
> can't be inlined because the function supports variable number of
> arguments.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> 
> ---
> Resend because of lack of response

Please do not resend patches. I prefer a ping request in the original thread.

By the way, you didn't take into account my first comments:
	http://dpdk.org/ml/archives/dev/2014-April/002028.html
and I'm still waiting answers to these patches:
	http://dpdk.org/ml/archives/dev/2014-March/001673.html
	http://dpdk.org/ml/archives/dev/2014-March/001676.html

PS: I was going to apply your patches with these fixes:
	add FILE argument to debug functions
		[Thomas: fix quota_watermark example]
	eal: dont inline string functions
		[Thomas: update includes]

-- 
Thomas


More information about the dev mailing list