[dpdk-dev] [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header

Thomas Monjalon thomas.monjalon at 6wind.com
Wed May 21 18:07:37 CEST 2014


2014-05-19 16:51, Anatoly Burakov:
> Creating code to handle VFIO interrupts in EAL interrupts, and also
> adding a header eal_vfio.h.

Maybe it's better to have 2 patches here.

> This header checks two things:
> * checks if CONFIG_RTE_EAL_VFIO was enabled during build time
> * checks that kernel version is 3.6+ so that DPDK would still compile
>   on older kernels despite VFIO compilation being enabled by default.

In case VFIO is backported on older kernel, it would be better to check a 
related macro instead of Linux version.
 
> This header also defines a VFIO_PRESENT macro, which should be used to
> conditionally compile all the VFIO code. This is because having
> CONFIG_RTE_EAL_VFIO enabled doesn't guarantee that the VFIO support is
> compiled in, because we're still dependent on kernel version.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>

> +	struct vfio_irq_set * irq_set;

There few lines like this one where checkpatch.pl reports an error:
	ERROR: "foo * bar" should be "foo *bar"

Thanks
-- 
Thomas


More information about the dev mailing list