[dpdk-dev] [PATCH v2 00/17] add TSO support
Olivier MATZ
olivier.matz at 6wind.com
Fri May 23 16:32:56 CEST 2014
Hi Konstantin,
> I don't see any big changes in the v2 of that patch.
>
> At least both things that I have concerns about, stay unchanged in
> the v2:
>
> 1) merge physaddr and buf_len in a bitfield - I still think we better
> keep physaddr as 64bit field (PATCH 5).
As nobody reacted to our discussion thread [1] with other arguments, I
stayed on my initial position:
- 2 bytes more in the mbuf structure is always good to have
- no performance impact detected (see my test reports)
- the 48 bits physical address limit will be reached in several years,
and at this time, maybe the cache lines will be 128 bytes? (solving
our initial rte_mbuf issue). So let's just deal with current or near
future hardware.
> 2) fix_tcp_phdr_cksum() is inside ixgbe TX function, while I think it
> should be moved out of it to the upper layer (PATCH 11).
Thomas's answer on this question [2] was to do that way, so I did not
modify the v1 patches.
Regards,
Olivier
[1] http://dpdk.org/ml/archives/dev/2014-May/002454.html
[2] http://dpdk.org/ml/archives/dev/2014-May/002531.html
More information about the dev
mailing list