[dpdk-dev] [PATCH v2 04/16] Make igb_uio compilation optional

Thomas Monjalon thomas.monjalon at 6wind.com
Tue May 27 10:49:01 CEST 2014


Hi HuilongX,

I have few comments.

2014-05-27 02:43, Xu, HuilongX:
> Currently, igb_uio is always compiled. Some Linux distribution may
> not want to include igb_uio by default, so we need to make sure that
> igb_uio compilation can be optional.

1) When replying to an email, there should be "> " in front of lines you have 
not written. Here, it's not easy to see what you are replying.

> Signed-off-by: Anatoly Burakov
> <anatoly.burakov at intel.com<mailto:anatoly.burakov at intel.com>>

> Test-by: HuilongX Xu <huilongx.xu at intel.com<mailto:huilongx.xu at intel.com>>
> Compile
> pass
> 
>      >>Compile OS: FC20 x86_64
>      >>Kernel version: 3.13.6-200
>      >>GCC version: 4.8.2
>      >>Server: Crownpass

2) Please do not copy all the patch if you have nothing specific to say about 
it.

-- 
Thomas


More information about the dev mailing list