[dpdk-dev] [PATCH v2 1/4]ethdev: add ethdev APIs for NIC filters of generic filter
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue May 27 11:18:34 CEST 2014
Hi LiX,
Thanks for testing patches.
In order to be more efficient next times, I have same comments as for
HuilongX.
2014-05-27 07:57, Ming, LiX:
> This patch adds APIs for NIC filters list below:
> ethertype filter, syn filter, 2tuple filter, flex filter, 5tuple filter
1) When replying to an email, there should be "> " in front of lines you have
not written. Here, it's not easy to see what you are replying.
> Test-by: lmingX lix,ming at intel.com
2) If you do some tests (other than compiling), please explain what are
the tests (command lines and environment).
> Compile pass
3) No need to notify that compilation is working. It's implicit (and
mandatory) when sending a patch.
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index a5727dd..afd4fe8 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
4) Please do not copy all the patch if you have nothing specific to say about
it.
Thanks for your help
--
Thomas
More information about the dev
mailing list