[dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Nov 3 08:41:53 CET 2014


2014-10-09 07:29, Neil Horman:
> On Thu, Oct 09, 2014 at 05:20:31AM +0000, Wu, Jingjing wrote:
> > Hi, Neil
> > 
> > To have rte_ip.h include netinet/in.h directly is also a choice.
> > 
> > But netinet/in.h contains a lot of extra stuff, and these may be useless some DPDK applications, such as classification.
> > rte_ip.h provides a more simplify way for the IP protocol layer.
> > 
> Not sure what the relevance there is.  The definitions you want are
> standardized, theres no need for the dpdk to re-invent that wheel.  Get them
> from the system include file.  The fact that extra macros are available in
> netinet.h is neither relevant or true (as you can't really say for certain what
> an application will need).

Neil, Matthew,

I totally agree with your point of view.
Please, could you propose a patch to fix this issue?

Thanks
-- 
Thomas


More information about the dev mailing list