[dpdk-dev] [PATCH v3 0/2] bond: mode 4 support

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Nov 7 14:48:29 CET 2014



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Friday, November 07, 2014 11:04 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
> 
> From: Pawel Wodkowski <pawelx.wodkowski at intel.com>
> 
> v2 changes:
> New version handles race issues with setting/cancelin callbacks,
> fixes promiscus mode setting in mode 4 and some other minor errors in
> mode 4
> implementation.
> 
> v3 changes:
> This is a rework of previous patchset. Basic functionality i the same but
> contain following changes:
> - use one global array of slaves instead separate instance for every bonded
>   device (reduce memory usage). This also allow use of port id instead of
>   offsetting to current active slaves.
> - make mode 4 immune to partner timings standard violation.
> - fix possible buffer overflow in RX function if caller provide buffer
>   that is less than received packets (additional slow packets).
> - change/fix promiscus mode and MAC management.
> - fix compiling issues on gcc version less than 4.5
> - bring API for tunig mode 4 parameters and expose mode 4 frames
> structure.
> - prevent console flood with warning messages if mode 4 RX/TX buffers are
> full.
> 
> test-pmd:
> - add mode 4 support (force periodic TX if no packets received during 100ms
>   period). Some forwardning modes (ex. rx only) does not allow mode 4
> usage.
> - 'port start X' - check if X is valid value
> 
> changes not related to mode 4:
> - fix memcpy() usage in bond_ethdev_tx_burst_balance() (OOM/undfined
> behaviour
>   if TX burst fail)
> 
> Those patches depend from Declan Doherty v5 (rebased to be aplicable on
> top of
> commit b6583ee402656ea86c8a3b92e009a99e13726781) patchset and rte
> alarm patches.

Since Declan sent a v6 for link bonding changes, maybe it is a good idea 
to send another version, as v5 will not be merged.

Pablo



More information about the dev mailing list