[dpdk-dev] [PATCH] i40e: support of link flow control
Thomas Monjalon
thomas.monjalon at 6wind.com
Thu Nov 13 10:46:57 CET 2014
Hi Zhida,
> Add support of link flow control.
>
> Signed-off-by: Zhida Zang <zhida.zang at intel.com>
> Acked-by: Helin Zhang <helin.zhang at intel.com>
I think you are reworking this patch, right?
I won't review it myself because I don't i40e enough.
I just have some minor comments:
> +static int i40e_10g_fc_enable(struct i40e_hw *hw, uint16_t pause_time)
"static int" should be on a separate line.
> + PMD_INIT_LOG(ERR, "i40e_set_fc = %d\n", err);
Carriage return is already included in PMD_INIT_LOG now.
Thanks for keep us informed of the status of this patch.
--
Thomas
More information about the dev
mailing list