[dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Nov 24 16:54:34 CET 2014


> > This patch fixes two occurances where a call to strncmp had the closing
> > brace in the wrong place. Changing this form:
> > 	if (strncmp(X,Y,sizeof(X) != 0))
> > which does a comparison of length 1, to
> > 	if (strncmp(X,Y,sizeof(X)) != 0)
> > which does the correct length comparison and then compares the result to
> > zero in the "if" part, as the author presumably originally intended.
> >
> > Reported-by: Larry Wang <liang-min.wang at intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> 
> Nice catch!
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>
 
Applied

Thanks
-- 
Thomas


More information about the dev mailing list