[dpdk-dev] [PATCH v6 00/22] Support flow director programming on Fortville

Wu, Jingjing jingjing.wu at intel.com
Tue Nov 25 05:51:34 CET 2014


Hi, Thomas

Thanks a lot.

> 
> I feel the flow director features could be better explained, and probably the
> API won't be enough generic for the next driver implementing flow director.
> But no comment from the community means it's OK to integrate.
> 
> Now we move on this API and the old one must be removed.
> Converting ixgbe to this new API must be the top priority.
> It must be clear to everyone that no new Fortville feature will be accepted
> until a full clean-up of the old filtering API.

If I understand correctly, what you mean is:
If the new patch is using new filter_ctrl API while the similar feature for
Igb and ixgbe are using the old filtering API, we need to clean-up the old filtering
API and promote them to new filtering APIs at first.
For example, if we want to enable ethertype filter on Fortville, we need to move
the igb/ixgbe's ether_type filter to new API at the same patchset.

What you said is not for others features which has no relationship with filter API. 
Correct? 
 
> 
> Thank you Jingjing for the big work. Step done.
> Applied
> --
> Thomas


More information about the dev mailing list