[dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop error

Neil Horman nhorman at tuxdriver.com
Mon Oct 6 16:50:20 CEST 2014


On Sun, Oct 05, 2014 at 07:37:11PM +0100, Nicolás Pernas Maradei wrote:
> Hi,
> 
> New in Patch v2:
> 
> - Fixes an issue in eth_dev_start/stop where a single interface was always
> opened/closed even though pcap files had been selected for rx/tx streams.
> - The link_status was not being properly updated in case of using a single
> interface for rx/tx streams.
> 
> Nico.
> 
> On 2014-10-04 23:24, Nicolás Pernas Maradei wrote:
> >From: Nicolás Pernas Maradei <nicolas.pernas.maradei at emutex.com>
> >
> >librte_pmd_pcap driver was opening the pcap/interfaces only at init time
> >and
> >closing them only when the port was being stopped. This behaviour would
> >cause
> >problems (leading to segfault) if the user closed the port 2 times. The
> >first
> >time the pcap/interfaces would be normally closed but libpcap would throw
> >an
> >error causing a segfault if the closed pcaps/interfaces were closed again.
> >This behaviour is solved by re-openning pcaps/interfaces when the port is
> >started (only if these weren't open already for example at init time).
> >
> >Signed-off-by: Nicolás Pernas Maradei <nico at emutex.com>
Acked-by: Neil Horman <nhorman at tuxdriver.com>



More information about the dev mailing list