[dpdk-dev] [pcap PATCH] pcap: fix build of all-in-one shared library

stepan stepan.sojka at adaptivemobile.com
Tue Oct 7 01:14:04 CEST 2014


Build of some of the test binaries fails when the following flags are enabled:

CONFIG_RTE_LIBRTE_PMD_PCAP=y
CONFIG_RTE_BUILD_SHARED_LIB=y
CONFIG_RTE_BUILD_COMBINE_LIBS=y

The binarieas are missing symbols from libpcap. This
patch adds the missing '-lpcap' linker flag into the respective Makefiles.

Signed-off-by: stepan <stepan.sojka at adaptivemobile.com>
---
 app/cmdline_test/Makefile | 4 ++++
 app/dump_cfg/Makefile     | 4 ++++
 app/test-acl/Makefile     | 4 ++++
 app/test/Makefile         | 4 ++++
 4 files changed, 16 insertions(+)

diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile
index e9eafd2..ce44fd5 100644
--- a/app/cmdline_test/Makefile
+++ b/app/cmdline_test/Makefile
@@ -47,6 +47,10 @@ SRCS-y += commands.c
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
+LDFLAGS += -lpcap
+endif
+
 include $(RTE_SDK)/mk/rte.app.mk
 
 endif
diff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile
index 3257127..513ce59 100644
--- a/app/dump_cfg/Makefile
+++ b/app/dump_cfg/Makefile
@@ -35,6 +35,10 @@ APP = dump_cfg
 
 CFLAGS += $(WERROR_FLAGS)
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
+LDFLAGS += -lpcap
+endif
+
 # all source are stored in SRCS-y
 
 SRCS-y := main.c
diff --git a/app/test-acl/Makefile b/app/test-acl/Makefile
index 43dfdcb..ea063fd 100644
--- a/app/test-acl/Makefile
+++ b/app/test-acl/Makefile
@@ -37,6 +37,10 @@ APP = testacl
 
 CFLAGS += $(WERROR_FLAGS)
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
+LDFLAGS += -lpcap
+endif
+
 # all source are stored in SRCS-y
 SRCS-y := main.c
 
diff --git a/app/test/Makefile b/app/test/Makefile
index 6af6d76..e456140 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -145,6 +145,10 @@ CFLAGS_test_kni.o += -Wno-deprecated-declarations
 endif
 CFLAGS += -D_GNU_SOURCE
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
+LDFLAGS += -lpcap
+endif
+
 # this application needs libraries first
 DEPDIRS-y += lib
 
-- 
1.8.4.GIT

*****************************************This email and any files transmitted with are confidential and intended solely for the use of the individual or entity to whom they are addressed.  If you have received this email in error then please delete it and notify the sender. Do not make a copy or forward it to anyone.  This footnote also confirms that this email message has been swept for the presence of computer viruses. Adaptive Mobile Security Ltd, Ferry House, 48 Lower Mount Street, Dublin 2, Ireland Directors: B. Collins, G. Maclachlan (UK), N. Grierson (UK), J. Ennis (UK), D. Summers (UK). Registered in Ireland, Company No. 370343, VAT Reg.No.IE6390343O*****************************************



More information about the dev mailing list