[dpdk-dev] [PATCH] Remove n_orig from __mempool_get_bulk() routine, cleanup comment.
Thomas Monjalon
thomas.monjalon at 6wind.com
Thu Oct 9 18:46:24 CEST 2014
Hi Keith,
2014-10-03 21:27, Wiles, Roger Keith:
> Cleanup the code some to remove n_orig variable that was not required.
> Update the comments to __mempool_get_bulk to state the correct return value.
>
> Signed-off-by: Keith Wiles <keith.wiles at windriver.com>
[...]
> * @return
> - * - >=0: Success; number of objects supplied.
> + * - 0: Success; number of objects requested.
> * - <0: Error; code of ring dequeue function.
> */
> static inline int __attribute__((always_inline))
> @@ -945,9 +945,6 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
> unsigned n, int is_mc)
Please, could you check ret? I think it can be >0.
Formatting comment: title should be
mempool: remove useless variable
Prefer short title, especially when behavior is not changed.
Thanks
--
Thomas
More information about the dev
mailing list