[dpdk-dev] [PATCH] Add Rx error statistics for Fortville
Zhang, Helin
helin.zhang at intel.com
Thu Oct 16 02:55:38 CEST 2014
Hi Thomas
Thank you very much for the detailed guidance! It is really helpful for me.
Regards,
Helin
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, October 15, 2014 8:22 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org; Liu, Jijiang
> Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
>
> Helin,
>
> As you are in charge of i40e, here are 2 tips to acknowledge patches:
>
> 1) title should take this format:
> i40e: add Rx error statistics
>
> > Acked-by: Helin Zhang <helin.zhang at intel.com>
>
> 2) This line should be added right after the Signed-off-by.
> And the rest of the email (patch body) can be removed.
> This way, your answer would be faster to read.
>
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu
> > > Sent: Wednesday, October 15, 2014 11:15 AM
> > > To: dev at dpdk.org
> > > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
>
> This header is not needed also.
>
> > > This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> > >
> > > Signed-off-by: Jijiang Liu <jijiang.liu at intel.com>
>
> [I remove the rest of the original email because I have no comment on it]
>
> Thanks
> --
> Thomas
More information about the dev
mailing list