[dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros

[Zhang, Helin]

Hi Thomas

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Saturday, October 18, 2014 4:59 AM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant
> macros
> 
> 2014-09-19 09:14, Helin Zhang:
> > To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and their
> > relevant macros need to be extern, and then can be used for both PF
> > and VF parts.
> >
> > Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> > Reviewed-by: Cunming Liang <cunming.liang at intel.com>
> > Reviewed-by: Jijiang Liu <jijiang.liu at intel.com>
> [...]
> > +#define I40E_RSS_OFFLOAD_ALL ( \
> > +	ETH_RSS_NONF_IPV4_UDP | \
> > +	ETH_RSS_NONF_IPV4_TCP | \
> > +	ETH_RSS_NONF_IPV4_SCTP | \
> > +	ETH_RSS_NONF_IPV4_OTHER | \
> > +	ETH_RSS_FRAG_IPV4 | \
> > +	ETH_RSS_NONF_IPV6_UDP | \
> > +	ETH_RSS_NONF_IPV6_TCP | \
> > +	ETH_RSS_NONF_IPV6_SCTP | \
> > +	ETH_RSS_NONF_IPV6_OTHER | \
> > +	ETH_RSS_FRAG_IPV6 | \
> > +	ETH_RSS_L2_PAYLOAD)
> > +
> > +/* All bits of RSS hash enable */
> > +#define I40E_RSS_HENA_ALL ( \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \
> > +	(1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD))
> 
> You've added the constants in the .h file but you forgot to remove them from
> the .c file.
Ohh, yes, you are right! Thank you for the good catch! And sorry for the inconvenience!


> 
> --
> Thomas

Regards,
Helin