[dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd

[Ouyang, Changchun]

Hi Pablo

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, October 21, 2014 4:19 PM
> To: Thomas Monjalon; Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> Hi Thomas,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, October 21, 2014 9:04 AM
> > To: Ouyang, Changchun
> > Cc: dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> >
> > 2014-10-21 14:59, Ouyang Changchun:
> > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > is
> > disabled.
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang at intel.com>
> >
> > Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> >
> > Applied
> 
> I was checking this patch right now, and I come across a second compilation
> issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> declared, and Bond PMD and IP fragmentation libraries use those functions.
> 
> I guess that it is late to NACK this :P, but we require a second patch to fix
> completely this issue.
As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)
In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
Yes, agree with you, we need another patch to fix compilation issue in other both places.