[dpdk-dev] [PATCH v3 3/8] i40e: support of setting hash lookup table size

Matthew Hall mhall at mhcomputing.net
Mon Oct 27 21:21:08 CET 2014


On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote:
> You didn't answer to my previous comment on this.
> I think these definitions are useless. 64 is 64.

Putting labels on the constants gives meaning to them as well as a numeric 
value. Not doing so is an antipattern referred to as "magic numbers" 
antipattern.

A maintainence programmer or community member will have a difficult time 
figuring out lost context when grepping through the code.

Matthew.


More information about the dev mailing list