[dpdk-dev] [PATCH] mk: link combined lib using CC

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Tue Oct 28 12:45:28 CET 2014



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Thursday, October 23, 2014 4:36 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: link combined lib using CC
> 
> Building combined shared libs fails if we set EXTRA_CFLAGS=-O0.
> 
> /usr/bin/ld: test: hidden symbol `mknod' in
> /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO
> /usr/bin/ld: final link failed: Bad value
> collect2: error: ld returned 1 exit status
> 
> Fix: link combined shared lib using CC if LINK_USING_CC is enabled.
> 
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy at intel.com>
> ---
>  mk/rte.lib.mk      |  1 -
>  mk/rte.sharelib.mk | 12 +++++++++++-
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index d83e808..a6abd6d 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -63,7 +63,6 @@ ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC) $(CPU_CFLAGS)
>  LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs)
> -CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
>  endif

Patch does not apply cleanly, due to context mismatch. 
Could you send a V2, based on the current branch status?

Plus, should we include compilation errors in commits? 
They are quite useful to identify the problem that 
the patch is solving, but not sure if this should be shown in the git log.

Thanks,
Pablo



More information about the dev mailing list