[dpdk-dev] [PATCH 04/15] i40e: remove test code for 'ethtool'

Helin Zhang helin.zhang at intel.com
Tue Sep 9 09:21:28 CEST 2014


The code wrapped in '#ifdef ETHTOOL_TEST' in i40e_diag.c is for
ethtool testing only, it is not needed anymore and can be removed.

Signed-off-by: Helin Zhang <helin.zhang at intel.com>
Reviewed-by: Chen Jing <jing.d.chen at intel.com>
---
 lib/librte_pmd_i40e/i40e/i40e_diag.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/lib/librte_pmd_i40e/i40e/i40e_diag.c b/lib/librte_pmd_i40e/i40e/i40e_diag.c
index f24bf81..167fcf8 100644
--- a/lib/librte_pmd_i40e/i40e/i40e_diag.c
+++ b/lib/librte_pmd_i40e/i40e/i40e_diag.c
@@ -71,11 +71,6 @@ static enum i40e_status_code i40e_diag_reg_pattern_test(struct i40e_hw *hw,
 		wr32(hw, reg, (pat & mask));
 		val = rd32(hw, reg);
 		if ((val & mask) != (pat & mask)) {
-#ifdef ETHTOOL_TEST
-			i40e_debug(hw, I40E_DEBUG_DIAG,
-				   "%s: reg pattern test failed - reg 0x%08x pat 0x%08x val 0x%08x\n",
-				   __func__, reg, pat, val);
-#endif
 			return I40E_ERR_DIAG_TEST_FAILED;
 		}
 	}
@@ -83,11 +78,6 @@ static enum i40e_status_code i40e_diag_reg_pattern_test(struct i40e_hw *hw,
 	wr32(hw, reg, orig_val);
 	val = rd32(hw, reg);
 	if (val != orig_val) {
-#ifdef ETHTOOL_TEST
-		i40e_debug(hw, I40E_DEBUG_DIAG,
-			   "%s: reg restore test failed - reg 0x%08x orig_val 0x%08x val 0x%08x\n",
-			   __func__, reg, orig_val, val);
-#endif
 		return I40E_ERR_DIAG_TEST_FAILED;
 	}
 
-- 
1.8.1.4



More information about the dev mailing list