[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

Wodkowski, PawelX pawelx.wodkowski at intel.com
Mon Sep 22 08:26:21 CEST 2014


> I think that will work, but I believe you're making it more complicated (and
> less reusable) than it needs to be.  What I think you really need to do is
> create a new rte api call, rte_eal_alarm_cancel_sync (something like the
> equivalent of del_timer_sync in linux, that wraps up the
> while(rte_eal_alarm_cancel(...) == 0) {rte_pause} in its own function (so other
> call sites can use it, as I don't think this is an uncommon problem), Then just
> create a bonding-internal state flag to signal the periodic callback that it
> shouldn't re-arm the timer.  That way all you have to do is set the flag, and
> call rte_eal_alarm_cancel_sync, and you're done.  And other applications will be
> able to handle this common type of operation as well
> 
> Neil

I agree with you that alarms should be upgraded but this need to discussed and 
tested. Now there is not time for that.

Thank you
Pawel


More information about the dev mailing list