[dpdk-dev] [PATCH v5 02/11] lib/librte_vhost: refactor vhost lib for subsequent transform

[Thomas Monjalon]

2014-09-29 21:55, Thomas Monjalon:
> 2014-09-26 17:45, Huawei Xie:
> > This patch does simple split of the original vhost example source
> > files in vhost lib directory.
> > vhost rx/tx functions virtio_dev_rx/tx are copied from main.c to
> > new file vhost_rxtx.c and license header is added.
> > main.c and main.h are removed and will be copied to new vhost
> > example in subsequent patch.
> > virtio-net.h is renamed to rte_virtio_net.h as API header file.
> > 
> > Signed-off-by: Huawei Xie <huawei.xie at intel.com>
> 
> You are removing functions for mergeable buffer feature.
> Please keep it instead of re-adding it later.

Other comment, you are silently increasing these values to 64:

 #define MAX_PKT_BURST 32               /* Max burst size for RX/TX */
 #define MAX_MRG_PKT_BURST 16   /* Max burst for merge buffers. Set to 1 due to performance issue. */

-- 
Thomas