[dpdk-dev] [PATCH] mbuf: clean old refcnt option

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Apr 3 15:57:39 CEST 2015


2015-04-03 05:10, Ouyang, Changchun:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > 2015-03-31 21:26, Olivier MATZ:
> > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote:
> > > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into
> > > > CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by
> > commit 4769bc5a27cc.
> > > > Some traces remain because of delayed patches.
> > > >
> > > > It can also be removed from doxygen config.
> > > > It is now poisoned in rte_mbuf.h to warn any misuse.
> > > >
> > > > Fixes: d0dff9ba445e ("doc: sample application user guide")
> > > > Fixes: fc1f2750a3ec ("doc: programmers guide")
> > > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt")
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
> > 
> > > I have one doubt about the vhost part, as the previous doc was telling
> > > to disable refcnt option and now the behavior is equivalent to having
> > > the option always enabled. Also you are removing parts of doc that
> > > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and
> > CONFIG_RTE_LIBRTE_IP_FRAG.
> > >
> > > It would be safer to also have an acknowledgment from a vhost expert.
> > 
> > Huawei, Changchun, any opinion please?
> 
> Ok to remove it from vhost user doc as the macro in code is removed.
> Thanks
> Changchun

Applied, thanks


More information about the dev mailing list