[dpdk-dev] [PATCH] Cleanup rte_memcpy.h

Ravi Kerur rkerur at gmail.com
Tue Apr 14 23:30:11 CEST 2015


rte_memcpy.h has
sperfluous type casting in several functions, remove those unnecessary casting.
while copying separate invocations of functions with changing offset, instead
offset can be calculated with loop.

Testing:
Compared code generated with and without changes with following gcc commands

gcc -O3 -m64 -S 

found no difference.

Tested on Ubuntu x86_64 (x86_64-native-linuxapp-gcc) with "make test"

Overall tests passed matches baseline.

Secondly memcpy performace tests take similar amount of time to finish.

/**********************With changes*************************************/
Start memcpy_perf:             Success                       [00m 00s]
Memcpy performance autotest:   Success                       [09m 36s] [17m 45s]
/**********************Without changes**********************************/
Start memcpy_perf:             Success                       [00m 00s]
Memcpy performance autotest:   Success                       [09m 35s] [13m 57s]

Ravi Kerur (1):
  Clean up rte_memcpy.h file

 .../common/include/arch/x86/rte_memcpy.h           | 317 ++++++++++-----------
 1 file changed, 151 insertions(+), 166 deletions(-)

-- 
1.9.1



More information about the dev mailing list