[dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c
Ravi Kerur
rkerur at gmail.com
Fri Apr 17 00:12:57 CEST 2015
On Thu, Apr 16, 2015 at 2:02 AM, Thomas Monjalon <thomas.monjalon at 6wind.com>
wrote:
> This patch is very sensible and difficult to follow.
> I'm really afraid that some nasty bugs could be hidden.
> Please could you try to split it in several steps?
> Thanks
>
Sure, will drop eal_pci_uio.c and eal_pci_vfio.c changes and will send out
new version.
>
> 2015-04-09 12:40, Ravi Kerur:
> > Changes in v5
> > Rebase to latest code.
> > Removed RTE_EXEC_ENV_BSDAPP from earlier changes.
> >
> > Changes in v4
> > Move common functions in eal_pci.c to librte_eal/common/
> > eal_common_pci.c file.
> >
> > Following functions are moved to eal_common_pci.c file.
> >
> > void *pci_map_resource(void *requested_addr, const int vfio_fd,
> > const char *devname, off_t offset, size_t size);
> > int pci_addr_comparison(struct rte_pci_addr *addr,
> > struct rte_pci_addr *addr2);
> > int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr,
> > struct rte_pci_device *dev);
> >
> > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in
> > common function.
> > Fix checkpatch warnings and errors.
> >
> > Changes in v3
> > N/A
> >
> > Changes in v2
> > N/A
> >
> > Changes in v1
> > N/A
> >
> > Signed-off-by: Ravi Kerur <rkerur at gmail.com>
> > ---
> > lib/librte_eal/bsdapp/eal/eal_pci.c | 122
> ++++-----------------------
> > lib/librte_eal/common/eal_common_pci.c | 130
> ++++++++++++++++++++++++++++-
> > lib/librte_eal/common/eal_private.h | 48 +++++++++++
> > lib/librte_eal/linuxapp/eal/eal_pci.c | 100 +---------------------
> > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 6 --
> > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 36 ++------
> > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 17 ++--
> > 7 files changed, 212 insertions(+), 247 deletions(-)
>
>
More information about the dev
mailing list