[dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs

[Iremonger, Bernard]

Hi Keith, Neil,

<snip>

> >> > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote:
> >> > > There is a dummy pci driver in the vdev PMD's at present.
> >> > > This RFC proposes to remove the pci driver from the vdev PMD's.
> >> > > Changes have been made to librte_ether to handle vdevs which do
> >> > > not
> >> > have a pci driver.
> >> > >
> >> > > The pdev PMD's should work as before with the changes to
> >>librte_ether
> >> > > The vdev PMD's which still have a pci driver should work as
> >> > > before
> >>with the
> >> > librte_ether changes.
> >> > >
> >> > > The following vdev PMD's have had the  pci driver removed
> >> > >
> >> > > bonding PMD
> >> > > null PMD
> >> > > pcap PMD
> >> > > ring PMD
> >> >
> >> > Any reason there is no patch for the af_packet driver?
> >> >
> >> > John
> >>
> >> I have just modified the Intel vdev PMD's.
> >> It would be best if the owners of the non Intel vdev's submitted
> >>patches for their drivers.
> >>
> >I disagree.  Its ok given that this is an RFC patch I suppose, but if
> >you intend to actually propose this change for review, you need to
> >modify all affected drivers in a single commit.  Asking individual
> >driver maintainers to submit patches to not access a struct element
> >that is removed in a separate patch will by definition cause FTBFS
> >errors.  All references to the structure member being removed must also
> >be eliminated in the same or a prior commit, preferably the former.
> 
> +1, if you introduce a chance that effects other places in the
> code/drivers then you must also make the changes to those parts as well.
> It really should not be an option IMO.
> >
> >Neil

< snip >

> Regards,
> ++Keith
> Intel Corporation
> 
> 
Firstly no struct element has been removed from struct rte_eth_dev {} in the eth_dev patch.
A dev_flags  element has been added to struct rte_eth_dev{}
A numa_node element has been added to struct rte_eth_dev_data{}.
Unmodified VDEV's and PDEV's will not be aware of these new elements and will be unaffected by the eth_dev changes.

Regards,

Bernard.