[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Dec 3 07:17:37 CET 2015


On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote:
> This issue was discovered under the case of software vm2vm
> fowarding. When pkts are received from virtio device 0 and
> tx_route to virtio device 1, tx of device 0 is not updated.
> 
> To fix this problem, we check each rx/tx branch to update
> stats. Besides, the stats are printed at a separated thread,
> so we design a mechanism to make sure unreasonable data will
> not show.

Fixing statistics for vm2vm case and designing a mechanism
to make sure unreasonable data will not sure are two different
things: they should be done in two different patches, but not
one.

So, again, please do not mix two (or more) things in one patch.

	--yliu


More information about the dev mailing list